Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-204][CL-345] fix web header truncation and stories #13318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Feb 9, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-345
https://bitwarden.atlassian.net/browse/CL-204

📔 Objective

  • fix web header component stories, which were previously disabled due to a runtime error
  • prevent content passed to the title-suffix slot from being truncated

📸 Screenshots

See "Web/Header" stories.

In the "Long Title" story, observe that the key icon is not truncated.

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 35.17%. Comparing base (03e8222) to head (741f581).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...s/web/src/app/layouts/header/web-header.stories.ts 0.00% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13318      +/-   ##
==========================================
- Coverage   35.18%   35.17%   -0.01%     
==========================================
  Files        3128     3129       +1     
  Lines       92667    92712      +45     
  Branches    16854    16854              
==========================================
+ Hits        32603    32610       +7     
- Misses      57606    57644      +38     
  Partials     2458     2458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Logo
Checkmarx One – Scan Summary & Details9db3cc65-b524-4bfb-b0ce-7007daee8d6a

Great job, no security vulnerabilities found in this Pull Request

@willmartian willmartian marked this pull request as ready for review February 10, 2025 03:39
@willmartian willmartian requested a review from a team as a code owner February 10, 2025 03:39
@willmartian willmartian requested a review from vleague2 February 10, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants