[PM-12681] Enable new Send Add/Edit Dialog on web

[djsmith85]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12681

📔 Objective

Re-using the new Send Add/Edit form, which was introduced with the browser extension refresh, on the web vault.

Changes

• Create web-specific new-send-dropdown component - 21ea12e
• Create web-specifc Send Add/Edit dialog - 85e67e6
• Use new-send-dropdown and replace old Send Add/Edit with new Add/Edit dialog - 89b4e2c
• Delete old Send Add/Edit component - b80fc5f
• Remove unused entries from en/messages.json - d8de1db
• Add cancel button to close dialog - f75f7bb
  • Added after the screenshots were taken

📸 Screenshots

Before	After

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 82 lines in your changes missing coverage. Please review.

Project coverage is 35.28%. Comparing base (65024a1) to head (49245bd).
Report is 20 commits behind head on main.

Files with missing lines	Patch %	Lines
.../web/src/app/tools/send/send-add-edit.component.ts	0.00%	41 Missing ⚠️
...tools/send/new-send/new-send-dropdown.component.ts	0.00%	25 Missing ⚠️
apps/web/src/app/tools/send/send.component.ts	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13361      +/-   ##
==========================================
- Coverage   35.29%   35.28%   -0.01%     
==========================================
  Files        3124     3129       +5     
  Lines       92358    92622     +264     
  Branches    16794    16824      +30     
==========================================
+ Hits        32597    32683      +86     
- Misses      57304    57494     +190     
+ Partials     2457     2445      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coroiu]

Approving platform changes

[audreyality]

👍🏻 Overall this is looking great! I pointed out a few things I was happy to see in the review.

📝 There's a bunch of nits and some questions.

[audreyality]

🎨 Consider subscribing to hasPremiumFromAnySource$ so that when premium status changes, the control updates immediately.

[djsmith85]

Added with fc57d15

[audreyality]

⛏️ Do you need to add takeUntil(this.destroyed$) to the operators? It doesn't seem to be triggering the lint, but might be a good idea regardless.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.8% Duplication on New Code

See analysis details on SonarQube Cloud