Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox mv3 build changes #13366

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Firefox mv3 build changes #13366

merged 2 commits into from
Feb 11, 2025

Conversation

justindbaur
Copy link
Member

🎟️ Tracking

📔 Objective

Update workflow to prepare for release of the MV3 version of our browser extension for Firefox. We are doing this change for both Opera and Firefox but they are done separately so that we can easily revert this PR if we run into issues during regression with the new version.

Related: #13365

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested a review from a team as a code owner February 11, 2025 21:09
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.29%. Comparing base (5f2a773) to head (45220fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13366   +/-   ##
=======================================
  Coverage   35.29%   35.29%           
=======================================
  Files        3124     3124           
  Lines       92349    92349           
  Branches    16793    16793           
=======================================
  Hits        32593    32593           
  Misses      57299    57299           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details3ff61463-01fb-4903-afa4-f652c522aaf8

Great job, no security vulnerabilities found in this Pull Request

@justindbaur justindbaur merged commit e3870a6 into main Feb 11, 2025
27 checks passed
@justindbaur justindbaur deleted the firefox-mv3-build-changes branch February 11, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants