Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17512] Remove unused "icon" class #13390

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Feb 13, 2025

๐ŸŽŸ๏ธ Tracking

PM-17512

๐Ÿ“” Objective

There were not any applied styles for this bootstrap class so it can be removed!

๐Ÿ“ธ Screenshots

N/A

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@nick-livefront nick-livefront requested a review from a team as a code owner February 13, 2025 18:31
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 35.32%. Comparing base (7984bb3) to head (81f6dd3).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13390       +/-   ##
===========================================
+ Coverage   15.76%   35.32%   +19.55%     
===========================================
  Files          27     3128     +3101     
  Lines        1884    92600    +90716     
  Branches        0    16826    +16826     
===========================================
+ Hits          297    32709    +32412     
- Misses       1587    57431    +55844     
- Partials        0     2460     +2460     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 2c72ba91-6b3d-4f66-a8b1-ef8282fce7d6

Great job, no security vulnerabilities found in this Pull Request

@nick-livefront nick-livefront merged commit be669a6 into main Feb 13, 2025
52 checks passed
@nick-livefront nick-livefront deleted the vault/pm-17513/remove-bootstrap branch February 13, 2025 20:34
jprusik pushed a commit to jprusik/clients that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants