[PM-18278] fix conditional in template #13392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13392 +/- ##
==========================================
- Coverage 35.33% 35.32% -0.01%
==========================================
Files 3129 3129
Lines 92579 92579
Branches 16807 16807
==========================================
- Hits 32713 32706 -7
- Misses 57427 57434 +7
Partials 2439 2439 ☔ View full report in Codecov by Sentry. |
| @@ -105,7 +105,7 @@ | |||
| class="tw-shrink-0" | |||
| > | |||
| <!-- "New" menu is always shown unless the user cannot create a cipher --> | |||
There was a problem hiding this comment.
🎨 Update this comment to match the new functionality, please.
|
|
Great job, no security vulnerabilities found in this Pull Request |
shane-melton
approved these changes
Feb 13, 2025
BTreston
deleted the
ac/pm-18278-New-Collection-button-is-missing-for-providers
branch
jprusik
pushed a commit
to jprusik/clients
that referenced
this pull request
Feb 14, 2025
* fix conditional in template * update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18278
📔 Objective
Fixes an issue where canCreateCiphers conditional overrides the canCreateCollections permission due to the structure of the template
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes