Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sso-routing): [PM-13458] Fixes for routing flow on TDE login #13479

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Patrick-Pimentel-Bitwarden
Copy link
Contributor

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden commented Feb 19, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13458

📔 Objective

We are not fixing it in the old UI because the new UI is going live imminently and it's not worth the effort to fix this as it's going away.

  • Fixed routing flow and added comments.

📸 Screenshots

Broken

Screen.Recording.2025-02-19.at.10.39.29.AM.mov

Fixed For TDE User

Screen.Recording.2025-02-21.at.3.55.54.PM.mov

Fixed for MP User

Screen.Recording.2025-02-21.at.4.57.43.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.35%. Comparing base (a19c860) to head (852c9a5).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
libs/auth/src/angular/sso/sso.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13479      +/-   ##
==========================================
+ Coverage   35.31%   35.35%   +0.03%     
==========================================
  Files        3138     3138              
  Lines       92963    93014      +51     
  Branches    16890    16917      +27     
==========================================
+ Hits        32834    32888      +54     
+ Misses      57669    57640      -29     
- Partials     2460     2486      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Logo
Checkmarx One – Scan Summary & Details01e06c66-6827-47c3-b296-d2f0e466cdbf

Great job, no security vulnerabilities found in this Pull Request

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden requested review from JaredSnider-Bitwarden and removed request for rr-bw February 19, 2025 17:26
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the entire handleForcePasswordReset flow in this component as it is not necessary w/ the SSO login strategy setting the flag into state which the auth guard will catch upon navigation to the vault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants