-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sso-routing): [PM-13458] Fixes for routing flow on TDE login #13479
base: main
Are you sure you want to change the base?
Conversation
…xed routing flow and added comments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13479 +/- ##
==========================================
+ Coverage 35.31% 35.35% +0.03%
==========================================
Files 3138 3138
Lines 92963 93014 +51
Branches 16890 16917 +27
==========================================
+ Hits 32834 32888 +54
+ Misses 57669 57640 -29
- Partials 2460 2486 +26 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
…did the old sso component flow because we determined it's not worth fixing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the entire handleForcePasswordReset
flow in this component as it is not necessary w/ the SSO login strategy setting the flag into state which the auth guard will catch upon navigation to the vault.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13458
📔 Objective
We are not fixing it in the old UI because the new UI is going live imminently and it's not worth the effort to fix this as it's going away.
📸 Screenshots
Broken
Screen.Recording.2025-02-19.at.10.39.29.AM.mov
Fixed For TDE User
Screen.Recording.2025-02-21.at.3.55.54.PM.mov
Fixed for MP User
Screen.Recording.2025-02-21.at.4.57.43.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes