Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-18276-Connect confirmation UI #13498

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented Feb 20, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18276

📔 Objective

📸 Screenshots

Screen.Recording.2025-02-20.at.5.10.46.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Project coverage is 35.35%. Comparing base (598139d) to head (0c03124).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
apps/browser/src/autofill/notification/bar.ts 0.00% 62 Missing ⚠️
.../components/notification/confirmation-container.ts 0.00% 24 Missing ⚠️
...autofill/content/components/notification/header.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13498      +/-   ##
==========================================
+ Coverage   35.33%   35.35%   +0.01%     
==========================================
  Files        3137     3139       +2     
  Lines       92935    93041     +106     
  Branches    16888    16924      +36     
==========================================
+ Hits        32838    32894      +56     
- Misses      57638    57661      +23     
- Partials     2459     2486      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Logo
Checkmarx One – Scan Summary & Details669a9772-0362-491d-84ea-0e5d66860e82

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /libs/common/src/tools/integration/rpc/rest-client.ts: 35
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant