Auth/PM-9417 - PasswordStrengthComp - A11y improvement - add screen reader announcement for password strength #13515
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… announcement for all usages of password strength.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13515 +/- ##
=======================================
Coverage 35.35% 35.35%
=======================================
Files 3138 3138
Lines 93014 93014
Branches 16917 16917
=======================================
+ Hits 32888 32889 +1
+ Misses 57640 57639 -1
Partials 2486 2486 ☔ View full report in Codecov by Sentry. |
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-9417
📔 Objective
To add screen reader announcements of the password strength score text as a user interacts w/ the field. Confirmed with design that we want this across the board with the component.
📸 Screenshots
PM-9417.-.Password.Strength.A11y.improvement.-.Input.password.registration.example.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes