Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8976] Migrate two-factor-setup component #13517

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

alec-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8976?atlOrigin=eyJpIjoiZWY3Yzc4OGVmMzk4NDgxOWFmZDIzNzBlZmNhNDdhNjkiLCJwIjoiaiJ9

📔 Objective

  • Removes Bootstrap styles from the two-factor-setup.component.html and replaces them with Tailwind equivalents
  • Adds a TwoFactorModule file to move away from LooseComponents and integrate bit-item
  • Replaces ul/li list with bit-item-group and bit-item

📸 Screenshots

Before

Screenshot 2025-02-21 at 1 11 30 PM

After

Screenshot 2025-02-21 at 1 52 45 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.76%. Comparing base (5384914) to head (21621c0).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (5384914) and HEAD (21621c0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5384914) HEAD (21621c0)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13517       +/-   ##
===========================================
- Coverage   35.35%   15.76%   -19.60%     
===========================================
  Files        3138       27     -3111     
  Lines       93014     1884    -91130     
  Branches    16917        0    -16917     
===========================================
- Hits        32888      297    -32591     
+ Misses      57640     1587    -56053     
+ Partials     2486        0     -2486     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 21, 2025

Logo
Checkmarx One – Scan Summary & Details276f5175-d864-4339-9b85-c87187dcf464

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant