-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8976] Migrate two-factor-setup component #13517
base: main
Are you sure you want to change the base?
[PM-8976] Migrate two-factor-setup component #13517
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13517 +/- ##
===========================================
- Coverage 35.35% 15.76% -19.60%
===========================================
Files 3138 27 -3111
Lines 93014 1884 -91130
Branches 16917 0 -16917
===========================================
- Hits 32888 297 -32591
+ Misses 57640 1587 -56053
+ Partials 2486 0 -2486 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8976?atlOrigin=eyJpIjoiZWY3Yzc4OGVmMzk4NDgxOWFmZDIzNzBlZmNhNDdhNjkiLCJwIjoiaiJ9
📔 Objective
two-factor-setup.component.html
and replaces them with Tailwind equivalentsbit-item
ul
/li
list withbit-item-group
andbit-item
📸 Screenshots
Before
After
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes