-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor(auth): initialize new logout lib #14970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
New Issues (1)Checkmarx found the following issues in this Pull Request
|
2116566
to
9f5ed94
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## rename-tsconfig #14970 +/- ##
===================================================
- Coverage 36.33% 36.33% -0.01%
===================================================
Files 3200 3199 -1
Lines 93302 93300 -2
Branches 16855 16855
===================================================
- Hits 33904 33902 -2
Misses 56962 56962
Partials 2436 2436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0c63d01
to
692078d
Compare
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21910
📔 Objective
In order to remove references in
@bitwarden/common
to@bitwarden/auth
I have created a new feature lib,@bitwarden/logout
, and moved theLogoutReason
type to it.This removes 11 out of 20 references to
@bitwarden/auth
from@bitwarden/common
and removes some references from@bitwarden/key-management
as a bonus.Taking things one step further: since the new library has no circular dependencies it can be set up to build with Nx. This involved adding
@nx/js
as a dependency so we can use itstsc
executor for building the project.Commits
Guides For Reviews
Key Management
We've just updated some of your import statements here.
Auth
We've moved the
LogoutReason
type out of@bitwarden/auth
and into a new library,@bitwarden/logout
. This allows us untangle many of the circular references between@bitwarden/common
and@bitwarden/auth
, among others. This establishes a feature based libs pattern in the monorepo, which is a step forward towards our goal of having small libs with a clear dependency graph.This new library is owned by auth and comes already integrated with Nx tooling.
Platform
I've updated some imports, clarified some CODEOWNERS rules, and added to our Nx configuration.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes