[deps]: Update electron to v34 #713
Open
+13
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
bitwarden-bot
changed the title
|
Internal tracking:
|
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/electron-34.x
branch
from
32e979a to
b0a65ba
Compare
renovate
bot
force-pushed
the
renovate/electron-34.x
branch
3 times, most recently
from
a8ce4fb to
04e4386
Compare
renovate
bot
force-pushed
the
renovate/electron-34.x
branch
from
04e4386 to
c7156a8
Compare
…patibility The minimize event in Electron 34 no longer provides an event object, requiring removal of the e.preventDefault() call.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=====================================
Coverage 2.23% 2.23%
=====================================
Files 60 60
Lines 2634 2634
Branches 467 467
=====================================
Hits 59 59
Misses 2572 2572
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues (69)Great job! The following issues were fixed in this Pull Request
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Required for electron-rebuild to work correctly with Electron 34. Previous transitive dependency version (3.68.0) was too old to support Electron 34.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
32.1.1->34.1.0Release Notes
electron/electron (electron)
v34.1.0: electron v34.1.0Compare Source
Release Notes for v34.1.0
Features
view.getVisible(). #45410 (Also in 35)document.executeCommand("paste"). #45472 (Also in 33, 35)Fixes
dialogmodule didn't work on Linux. #45395 (Also in 35)Other Changes
NSPrefersDisplaySafeAreaCompatibilityMode=falseto Info.plist to remove "Scale to fit below built-in camera." from app options. #45469 (Also in 33, 35)v34.0.2: electron v34.0.2Compare Source
Release Notes for v34.0.2
Fixes
shell.readShortcutLinkcaused byPKEY_AppUserModel_ToastActivatorCLSIDsometimes being represented by a string uuid. #45350 (Also in 33)chrome.tabs.update(). #45304 (Also in 33, 35)Other Changes
v34.0.1: electron v34.0.1Compare Source
Release Notes for v34.0.1
Fixes
getAsFileSystemHandleto never resolve. #45258 (Also in 33, 35)avoidClosingConnectionsoption forsession.clearDatanow properly defaults tofalsewhen thedataTypesoption is not set. #45208 (Also in 33)v34.0.0: electron v34.0.0Compare Source
Release Notes for v34.0.0
Stack Upgrades
132.0.6834.8320.18.113.2Breaking Changes
Features
Additions
session.getSharedDictionaryUsageInfo(),session.getSharedDictionaryInfo(options),session.clearSharedDictionaryCache(), andsession.clearSharedDictionaryCacheForIsolationKey(options). #44950 (Also in 33)WebFrameMain.collectJavaScriptCallStack()for accessing the JavaScript call stack of unresponsive renderers. #44938 (Also in 33)WebFrameMain.detachedfor frames in an unloading state.WebFrameMain.isDestroyed()to determine if a frame has been destroyed.webFrameMain.fromId(processId, frameId)returning aWebFrameMaininstance which doesn't match the given parameters when the frame is unloading. #43473 (Also in 33)desktopCapturerandsetDisplayMediaRequestHandler. #43581 (Also in 32, 33)Improvements
Fixes
Also in earlier versions...
MenuItem.clickhandler not settingfocusedWindowparameter when focused window is aBaseWindow. #43404 (Also in 31, 32, 33)chrome.i18nextension API being unavailable in service workers. #45036 (Also in 31, 32, 33)trace-startupnot working on macOS. #44275 (Also in 32, 33)enable_pluginsbuild flag is false. #44003 (Also in 33)shell.readShortcutLinkon Windows. #44804 (Also in 33)focuson aWebView'swebContents. #43921 (Also in 31, 32, 33)setWindowOpenHandler. #43775 (Also in 31, 32, 33)BaseWindow.setTouchBardidn't work as expected. #43353 (Also in 30, 31, 32, 33)EventSourcewasundefinedin both renderer and worker processes when Node.js integration was enabled. #44495 (Also in 32, 33)WebContentsViews did not show correctly in some circumstances on macOS after being added as child views. #43638 (Also in 31, 32, 33)WebContentsViews were being improperly removed. #44670 (Also in 31, 32, 33)defaultPathdid not work for all users on Linux when creating an open file dialog. #43570 (Also in 30, 31, 32, 33)resizewasn't being emitted for single-pixel resizes on Windows. #44722 (Also in 32, 33)utilityProcesspid would not beundefinedafter exit. #44695 (Also in 32, 33)exitevent could be emitted twice from theutilityProcess. #44265 (Also in 31, 32, 33)context-menuevent was not emitted when using-webkit-app-region: drag. #44799 (Also in 32, 33)resizeevents being emitted on Windows when the window was moved but not resized. #43431 (Also in 32, 33)context-menuevent. #44952 (Also in 32, 33)getDisplayMediafrom multiple iframes. #43905 (Also in 33)webContents.canGoToOffset. #45008 (Also in 32, 33)libgdk_pixbuf. #44438 (Also in 32, 33)Content-Dispositionheader parsing. #43611 (Also in 30, 31, 32, 33)Other Changes
3823947. #45023sender-idhint is set when creating desktop notifications on DBus. #43928 (Also in 31, 32, 33)Documentation
Notices
End of Support for 31.x.y
Electron 31.x.y has reached end-of-support as per the project's support policy. Developers and applications are encouraged to upgrade to a newer version of Electron.
v33.4.0: electron v33.4.0Compare Source
Release Notes for v33.4.0
Features
document.executeCommand("paste"). #45473 (Also in 34, 35)Fixes
shell.readShortcutLinkcaused byPKEY_AppUserModel_ToastActivatorCLSIDsometimes being represented by a string uuid. #45349 (Also in 34)Other Changes
NSPrefersDisplaySafeAreaCompatibilityMode=falseto Info.plist to remove "Scale to fit below built-in camera." from app options. #45470 (Also in 34, 35)v33.3.2: electron v33.3.2Compare Source
Release Notes for v33.3.2
Fixes
chrome.tabs.update(). #45303getAsFileSystemHandleto never resolve. #45257 (Also in 34, 35)avoidClosingConnectionsoption forsession.clearDatanow properly defaults tofalsewhen thedataTypesoption is not set. #45207 (Also in 34)Other Changes
3845650.3798697. #45158v33.3.1: electron v33.3.1Compare Source
Release Notes for v33.3.1
Fixes
chrome.i18nextension API being unavailable in service workers. #45037 (Also in 31, 32, 34)webContents.canGoToOffset. #45006 (Also in 32, 34)Other Changes
v33.3.0: electron v33.3.0Compare Source
Release Notes for v33.3.0
Features
session.getSharedDictionaryUsageInfo(),session.getSharedDictionaryInfo(options),session.clearSharedDictionaryCache(), andsession.clearSharedDictionaryCacheForIsolationKey(options). #44951 (Also in 34)WebFrameMain.collectJavaScriptCallStack()for accessing the JavaScript call stack of unresponsive renderers. #44937 (Also in 34)Fixes
context-menuevent. #44953 (Also in 32, 34)Other Changes
Documentation
v33.2.1: electron v33.2.1Compare Source
Release Notes for v33.2.1
Fixes
shell.readShortcutLinkon Windows. #44803 (Also in 34)WebContentsViews were being improperly removed. #44671 (Also in 31, 32, 34)resizewasn't being emitted for single-pixel resizes on Windows. #44723 (Also in 32, 34)utilityProcesspid would not beundefinedafter exit. #44694 (Also in 32, 34)context-menuevent was not emitted when using-webkit-app-region: drag. #44800 (Also in 32, 34)Other Changes
v33.2.0: electron v33.2.0Compare Source
Release Notes for v33.2.0
Features
Other Changes
v33.1.0: electron v33.1.0Compare Source
Release Notes for v33.1.0
Features
WebFrameMain.detachedfor frames in an unloading state.WebFrameMain.isDestroyed()to determine if a frame has been destroyed.webFrameMain.fromId(processId, frameId)returning aWebFrameMaininstance which doesn't match the given parameters when the frame is unloading. #44209Fixes
EventSourcewasundefinedin both renderer and worker processes when Node.js integration was enabled. #44496 (Also in 32, 34)libgdk_pixbuf. #44436 (Also in 32, 34)Other Changes
v33.0.2: electron v33.0.2Compare Source
Release Notes for v33.0.2
Fixes
trace-startupnot working on macOS. #44276 (Also in 32, 34)exitevent could be emitted twice from theutilityProcess. #44266 (Also in 31, 32, 34)v33.0.1: electron v33.0.1Compare Source
Release Notes for v33.0.1
Other Changes
v33.0.0: electron v33.0.0Compare Source
Release Notes for 33.0.0
Stack Upgrades
130.0.6723.4420.18.013.0Breaking Changes
texturedBrowserWindowtypeoption on macOS. #43133protocol.registerFileProtocoland thebaseURLForDataURLproperty onBrowserWindow.loadURL,WebContents.loadURL, and<webview>.loadURL. #43977Features
Additions
app.setClientCertRequestPasswordHandler(handler), to help unlock cryptographic devices when a PIN is needed. #41205View.setBorderRadius(radius)for customizing the border radius of views—with compatibility forWebContentsView. #42320desktopCapturerandsetDisplayMediaRequestHandler. #43680 (Also in 32)DownloadItem.getCurrentBytesPerSecond(),DownloadItem.getPercentComplete(),DownloadItem.getEndTime(). #42805 (Also in 30, 31, 32)prefersReducedTransparencytonativeTheme, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings. #42862 (Also in 30, 31, 32)app#loginevent. #42631 (Also in 32)Improvements
navigationHistoryAPI with 2 new functions for better history management. #42014sender-idhint is set when creating desktop notifications on DBus. #43949 (Also in 31, 32)systemPreferencestoutilityProcess. #42203 (Also in 30, 31, 32)Fixes
enable_pluginsbuild flag is false. #44025Also in earlier versions...
MenuItem.clickhandler not settingfocusedWindowparameter when focused window is aBaseWindow. #43438 (Also in 31, 32)focuson aWebView'swebContents. #43932 (Also in 31, 32)BrowserWindow.setTopBrowserView. #42653 (Also in 30, 31, 32)webContents.close()on a BrowserView. #42633 (Also in 31, 32)setWindowOpenHandler. #43816 (Also in 31, 32)postMessage. #42535 (Also in 30, 31, 32)BaseWindow.setTouchBardidn't work as expected. #43422 (Also in 30, 31, 32)WebContentsViews did not show correctly in some circumstances on macOS after being added as child views. #43696 (Also in 31, 32)defaultPathdid not work for all users on Linux when creating an open file dialog. #43595 (Also in 30, 31, 32)fetch-dependent interfaces could be missing in Web Workers withnodeIntegrationInWorkerenabled. #42579 (Also in 30, 31, 32)navigator.mediaDevices.enumerateDevicescould retur