-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17915] feat: disable archived google users #715
base: main
Are you sure you want to change the base?
[PM-17915] feat: disable archived google users #715
Conversation
Thanks @hendrikheil! I've created an internal ticket for us to track this. This seems reasonable to me but I'm double checking with our integrations team. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
=====================================
Coverage 2.23% 2.23%
=====================================
Files 60 60
Lines 2634 2634
Branches 467 467
=====================================
Hits 59 59
Misses 2572 2572
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, passing to QA to do some manual testing on before merging.
Sounds good 👍 . Heads up for anyone finding this through a search engine in the future. It's important to remove |
Thank you for your contribution! We've added this to our internal Community PR board for review. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17453
📔 Objective
This PR changes the way Google Workspace users are marked as disabled. Google Workspace provides a way to archive users, which maintains their accounts and data but also disabled access.
Suspended users are charged as regular licenses by Google, where as archived users are billed at a reduced rate, which is ideal for employees leaving a company.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes