Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1594] - exempt bitwarden/gh-actions from hash check #202

Merged

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Oct 24, 2023

๐ŸŽŸ๏ธ Tracking

๐Ÿšง Type of change

  • ๐Ÿค– Build/deploy pipeline (DevOps)

๐Ÿ“” Objective

  • For Workflow linting, exempt bitwarden/gh-action hashes check

๐Ÿ“‹ Code changes

  • lint-workflow/lint.py: Make linter skip bitwarden/gh-action hashes check

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner October 24, 2023 14:09
@Eeebru Eeebru requested review from a team and removed request for a team October 24, 2023 14:09
@Eeebru Eeebru merged commit 3308d10 into master Oct 24, 2023
1 check passed
@Eeebru Eeebru deleted the DEVOPS-1594-pin-all-uses-of-bitwarden-gh-actions-to-master branch October 24, 2023 14:17
@bitwarden-bot
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 8c878a52-4d7c-4e29-ab5e-70effa3ed6d0

No New Or Fixed Issues Found

@Eeebru Eeebru self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants