Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-265-slack-commit-link #340

Merged
merged 6 commits into from
Nov 5, 2024
Merged

BRE-265-slack-commit-link #340

merged 6 commits into from
Nov 5, 2024

Conversation

pixman20
Copy link
Contributor

@pixman20 pixman20 commented Nov 5, 2024

🎟️ Tracking

BRE-265

📔 Objective

Updates slack notifications to use links for tag/branch and commit information.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@pixman20 pixman20 requested a review from a team as a code owner November 5, 2024 16:52
@pixman20 pixman20 marked this pull request as draft November 5, 2024 17:13
@pixman20 pixman20 self-assigned this Nov 5, 2024
@pixman20 pixman20 marked this pull request as ready for review November 5, 2024 18:42
@pixman20 pixman20 merged commit 638a3ea into main Nov 5, 2024
7 checks passed
@pixman20 pixman20 deleted the BRE-265-slack-commit-link branch November 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants