Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Renovate reference in dependency #347

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

withinfocus
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

#345

๐Ÿ“” Objective

There's a reference to Renovate in a dependency, so just to avoid the linked issue we can remove it. Also tells Prettier to not look at these files.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review November 14, 2024 16:03
@withinfocus withinfocus requested a review from a team as a code owner November 14, 2024 16:03
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ a47ef474-ad42-4664-bdca-69dc93191a8f

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /workflow-linter.yml: 50

@withinfocus withinfocus merged commit 0947212 into main Nov 14, 2024
8 checks passed
@withinfocus withinfocus deleted the renovate-package branch November 14, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants