Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-292: Add workflow for ephemeral environment management #357

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

mimartin12
Copy link
Contributor

🎟️ Tracking

📔 Objective

This intends to take the existing workflow here https://github.com/bitwarden/devops/blob/main/.github/workflows/_ephemeral_environment_pr_manager.yml and bring it into a public repository. So that we can leverage it in CI workflows directly. Instead of calling await github.rest.actions.createWorkflowDispatch. This allows the status of the called workflow to be present directly in the user's CI status.

This also adds additional sync_environment feature that were in the PR here. https://github.com/bitwarden/devops/pull/2957. This adds an input that, when called, syncs the environment based on the pull request.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mimartin12 mimartin12 requested a review from a team as a code owner December 17, 2024 22:16
Copy link

github-actions bot commented Dec 17, 2024

Logo
Checkmarx One – Scan Summary & Details547ea014-2058-41e3-8218-f38edb42ed22

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2024-21538 Npm-cross-spawn-7.0.3 Vulnerable Package
HIGH CVE-2024-45296 Npm-path-to-regexp-6.2.1 Vulnerable Package
HIGH Cx687dda59-2e3a Npm-unzip-stream-0.3.1 Vulnerable Package
HIGH Cxdca8e59f-8bfe Npm-inflight-1.0.6 Vulnerable Package
MEDIUM CVE-2021-34532 Nuget-Microsoft.AspNetCore.Authentication.JwtBearer-3.0.0 Vulnerable Package
MEDIUM CVE-2024-24758 Npm-undici-5.28.2 Vulnerable Package
MEDIUM CVE-2024-30260 Npm-undici-5.28.2 Vulnerable Package
MEDIUM CVE-2024-4067 Npm-micromatch-4.0.5 Vulnerable Package
LOW CVE-2024-30261 Npm-undici-5.28.2 Vulnerable Package
LOW Cx8bc4df28-fcf5 Npm-debug-4.3.4 Vulnerable Package

pixman20
pixman20 previously approved these changes Dec 18, 2024
Eeebru
Eeebru previously approved these changes Dec 19, 2024
@mimartin12 mimartin12 merged commit 9432784 into main Dec 19, 2024
5 checks passed
@mimartin12 mimartin12 deleted the BRE-292-gh-workflow-for-ee-sync branch December 19, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants