-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAS-536 | Add support for AuthenticatorDisplayName
#713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add migrations, corect?
@abergs yes, correct |
This needs a new release of Passwordless.NET and a package update to resolve missing references |
Added migrations and updated the Passwordless.NET SDK version to Once that package is released, this PR should technically be good to merge. Would still need to run some smoke tests for good measure, however. |
@@ -16,53 +16,32 @@ | |||
|
|||
namespace Passwordless.Service; | |||
|
|||
public class Fido2Service : IFido2Service | |||
public class Fido2Service( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only formatting changes here except line 251
Should be ready |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 35.15% 35.56% +0.40%
==========================================
Files 579 584 +5
Lines 31252 32202 +950
Branches 949 950 +1
==========================================
+ Hits 10988 11452 +464
- Misses 20119 20603 +484
- Partials 145 147 +2 ☔ View full report in Codecov by Sentry. |
Waiting on: bitwarden/passwordless-dotnet#152