Skip to content

PM-23654: Map CXF totp #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 14, 2025
Merged

PM-23654: Map CXF totp #381

merged 9 commits into from
Aug 14, 2025

Conversation

abergs
Copy link
Member

@abergs abergs commented Aug 13, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23654

📔 Objective

This PR maps CXF totp during import

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@abergs abergs changed the base branch from main to cxf/sample August 13, 2025 08:44
@abergs abergs marked this pull request as ready for review August 13, 2025 08:44
@abergs abergs requested a review from a team as a code owner August 13, 2025 08:44
@abergs abergs requested review from coroiu and Hinton and removed request for a team and coroiu August 13, 2025 08:44
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Logo
Checkmarx One – Scan Summary & Detailsfcd4c7ad-b426-4346-9133-41068141ed58

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 98.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.76%. Comparing base (4153278) to head (e8cc922).

Files with missing lines Patch % Lines
crates/bitwarden-exporters/src/cxf/import.rs 97.57% 4 Missing ⚠️
crates/bitwarden-exporters/src/cxf/totp.rs 98.90% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           cxf/sample     #381      +/-   ##
==============================================
+ Coverage       74.37%   74.76%   +0.38%     
==============================================
  Files             253      254       +1     
  Lines           21918    22264     +346     
==============================================
+ Hits            16302    16645     +343     
- Misses           5616     5619       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abergs abergs requested a review from Hinton August 14, 2025 12:34
@abergs abergs requested a review from Hinton August 14, 2025 15:15
Copy link

@abergs abergs merged commit 2336543 into cxf/sample Aug 14, 2025
47 checks passed
@abergs abergs deleted the cxf/totp branch August 14, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants