Skip to content

[no ticket] Fix wasm being imported on UNIFFI builds #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025
Merged

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Aug 14, 2025

🎟️ Tracking

https://bitwarden.slack.com/archives/C054ZQSBS49/p1755188403409309

📔 Objective

It seems #279 accidentally required wasm in all uniffi builds via bitwarden-vault -> bitwarden-collections -> bitwarden-core. Since it is only required on core, this leads to build issues on anything where an impl is tagged with wasm-bindgen, but uses a struct from a third package - such as bitwarden-crypto that does not have the wasm feature enabled.

Attempts to fix the build errors of: #383

Note: This flags out a function from the collections client. This has to be fixed by the owning team and updated, this PR just unblocks builds and fixes the imports.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from jrmccannon August 14, 2025 15:52
@quexten quexten changed the title Fix wasm being imported on UNIFFI builds [no ticket] Fix wasm being imported on UNIFFI builds Aug 14, 2025
Copy link
Contributor

github-actions bot commented Aug 14, 2025

Logo
Checkmarx One – Scan Summary & Detailsad70deae-15e5-43ec-901b-78f457d44f20

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.19%. Comparing base (bceb681) to head (e1ce8d5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   74.19%   74.19%           
=======================================
  Files         253      253           
  Lines       21897    21897           
=======================================
  Hits        16247    16247           
  Misses       5650     5650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten marked this pull request as ready for review August 14, 2025 16:25
@quexten quexten requested review from a team as code owners August 14, 2025 16:25
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@quexten quexten enabled auto-merge (squash) August 14, 2025 17:05
@quexten quexten disabled auto-merge August 14, 2025 17:06
@quexten quexten enabled auto-merge (squash) August 14, 2025 17:21
@quexten quexten disabled auto-merge August 14, 2025 17:35
@quexten quexten enabled auto-merge (squash) August 14, 2025 17:36
@quexten quexten merged commit 20e3dfa into main Aug 14, 2025
50 checks passed
@quexten quexten deleted the fix-wasm-import branch August 14, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants