Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wasm2js breaking wasm builds #1149

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: wasm2js breaking wasm builds #1149

merged 1 commit into from
Oct 21, 2024

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Oct 21, 2024

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 8b692432-425e-49ab-aaa3-18bd724d98f8

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 61 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-python.yml: 108 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 163 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 44 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-napi.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 96 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 173 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 86 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 77 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 131 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 87 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 169 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 338 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 93 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 52 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 87 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 163 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 86 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 173 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 131 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 54 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-swift.yml: 96 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 169 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 77 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-python.yml: 108 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 61 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /release-bws.yml: 44 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 338 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /release-bws.yml: 52 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 93 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-napi.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 76
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 43
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 85
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 337
MEDIUM Unpinned Actions Full Length Commit SHA /publish-python.yml: 107
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 60
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 86
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 162
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 53
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 53
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 92
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 172
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 168
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 51
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 130
MEDIUM Unpinned Actions Full Length Commit SHA /publish-napi.yml: 110
LOW Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 76
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 85
LOW Unpinned Actions Full Length Commit SHA /publish-napi.yml: 110
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 172
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 92
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 162
LOW Unpinned Actions Full Length Commit SHA /release-bws.yml: 43
LOW Unpinned Actions Full Length Commit SHA /publish-bws.yml: 168
LOW Unpinned Actions Full Length Commit SHA /release-bws.yml: 51
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 337
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 130
LOW Unpinned Actions Full Length Commit SHA /build-swift.yml: 95
LOW Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 86
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 60
LOW Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 53
LOW Unpinned Actions Full Length Commit SHA /publish-python.yml: 107

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.15%. Comparing base (6460db2) to head (f7fdeb5).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   58.17%   58.15%   -0.03%     
==========================================
  Files         197      197              
  Lines       13587    13587              
==========================================
- Hits         7904     7901       -3     
- Misses       5683     5686       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroiu
fix: downgrade rust to 1.81.0 in WASM builds
f7fdeb5 
this is a temporary fix for WASM no longer building due to wasm2js
breaking when using 1.82.0
@coroiu coroiu changed the title wip: test downgrading rust to 1.81.0 fix: wasm2js breaking wasm builds Oct 21, 2024
@coroiu coroiu marked this pull request as ready for review October 21, 2024 12:35
@coroiu coroiu merged commit c5a7419 into main Oct 21, 2024
99 of 100 checks passed
@coroiu coroiu deleted the ps/fix-wasm-build-issue branch October 21, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coroiu @dani-garcia