[PM-6262] Add basic feature flags support to enable cipher key encryption #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 59.50% 60.53% +1.03%
==========================================
Files 171 172 +1
Lines 10416 10527 +111
==========================================
+ Hits 6198 6373 +175
+ Misses 4218 4154 -64 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues
|
Hinton
reviewed
Mar 1, 2024
Comment on lines
+9
to
+13
| let map = map | ||
| .into_iter() | ||
| .map(|(k, v)| (k, serde_json::Value::Bool(v))) | ||
| .collect(); | ||
| serde_json::from_value(serde_json::Value::Object(map)).expect("Valid map") |
There was a problem hiding this comment.
Serde 😢, we could write a proc macro for this but unsure if it's worth the hassle.
There was a problem hiding this comment.
We could even do a small declarative macro that just does:
this_flag = map.get("this_flag").unwrap_or(false);
that_flag = map.get("that_flag").unwrap_or(false);
another_flag = map.get("another_flag").unwrap_or(false);
That said I think we can deal with that when we have more flags to handle.
Hinton
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Implement support for some basic feature flagging for the mobile clients, the only flag supported is
enableCipherKeyEncryption