Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6113] Build rust authenticator and client to support iOS and Android passkey provider implementation #644

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Mar 1, 2024

## Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please add unit tests where it makes sense to do so

@bitwarden-bot
Copy link

bitwarden-bot commented Mar 1, 2024

Logo
Checkmarx One – Scan Summary & Detailsf2eb1f02-00a0-44a7-808c-c446007d2f60

No New Or Fixed Issues Found

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 461 lines in your changes missing coverage. Please review.

Project coverage is 58.03%. Comparing base (596ce17) to head (42e53ee).
Report is 344 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden/src/platform/fido2/transaction.rs 0.00% 101 Missing ⚠️
crates/bitwarden-wasm/src/fido2/channel_wrapper.rs 0.00% 65 Missing ⚠️
crates/bitwarden/src/platform/fido2/fido2.rs 0.00% 54 Missing ⚠️
crates/bitwarden-wasm/src/fido2/user_interface.rs 0.00% 50 Missing ⚠️
crates/bitwarden/src/platform/fido2/crypto.rs 0.00% 38 Missing ⚠️
crates/bitwarden-wasm/src/client.rs 0.00% 29 Missing ⚠️
...rates/bitwarden-wasm/src/fido2/credential_store.rs 0.00% 27 Missing ⚠️
...den/src/platform/fido2/client_create_credential.rs 0.00% 27 Missing ⚠️
crates/bitwarden/src/platform/fido2/guid.rs 0.00% 21 Missing ⚠️
crates/bitwarden/src/platform/fido2/vault_item.rs 0.00% 20 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   60.61%   58.03%   -2.58%     
==========================================
  Files         170      182      +12     
  Lines       10387    10848     +461     
==========================================
  Hits         6296     6296              
- Misses       4091     4552     +461     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coroiu and others added 21 commits March 4, 2024 13:42
…key-rs

Not yet supported in `bitwarden-wasm`
We have either a race condition or we've missed calling a function somewhere
…to-support-i-os-and-android-passkey-provider-implementation
@coroiu coroiu closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants