Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract shared metadata to workspace and link #661

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Mar 14, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

  • Extract shared metadata into the workspace Cargo.toml and link packages to use it. This ensures we have a single point of truth and will simplify updating.
  • Added publish = false to all packages that are not published on crates.io to prevent accidental publication.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia March 14, 2024 11:26
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (dd440ba) to head (7e1e60f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #661   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         172      172           
  Lines       10553    10553           
=======================================
  Hits         6373     6373           
  Misses       4180     4180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Mar 14, 2024

Logo
Checkmarx One – Scan Summary & Detailsa815ed3e-5cfa-4123-882d-92d7a5b69231

No New Or Fixed Issues Found

dani-garcia
dani-garcia previously approved these changes Mar 15, 2024
@Hinton Hinton requested a review from dani-garcia March 15, 2024 15:41
@Hinton Hinton merged commit d2742c8 into main Mar 15, 2024
69 checks passed
@Hinton Hinton deleted the ps/cargo-workspace branch March 15, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants