Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit comment to fix new nightly builds #778

Merged
merged 1 commit into from
May 13, 2024
Merged

Edit comment to fix new nightly builds #778

merged 1 commit into from
May 13, 2024

Conversation

dani-garcia
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This was breaking due to some changes to the formatter in nightly that were formatting a comment that was previously fine: https://github.com/bitwarden/sdk/actions/runs/9059887702/job/24888426878

To avoid it being split over three lines, I just moved it above the line

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb4bf7fd9-ac3f-43f5-9826-af7cda667cbf

No New Or Fixed Issues Found

@dani-garcia dani-garcia requested a review from Hinton May 13, 2024 08:53
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.69%. Comparing base (e81b5ea) to head (106a645).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #778   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files         177      177           
  Lines       11501    11501           
=======================================
  Hits         6751     6751           
  Misses       4750     4750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia merged commit c54a360 into main May 13, 2024
92 checks passed
@dani-garcia dani-garcia deleted the ps/nightly-fmt branch May 13, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants