Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1288] - Configure renovate to track go dependencies #811

Merged
merged 1 commit into from
May 31, 2024

Conversation

tangowithfoxtrot
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot commented May 30, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1288

📔 Objective

Configure dependency tracking for the Go wrapper. Dependency upgrades should be tracked here, rather than the bitwarden/sm-sdk-go repo, since this is the source for what gets pushed there.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review May 30, 2024 16:07
@tangowithfoxtrot tangowithfoxtrot requested a review from a team May 30, 2024 16:08
@tangowithfoxtrot tangowithfoxtrot changed the title configure renovate to track go depenedencies [SM-1288] - Configure renovate to track go depenedencies May 30, 2024
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details754e478a-8293-4406-9669-68d72873d1e1

No New Or Fixed Issues Found

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.02%. Comparing base (9eb4237) to head (05ac233).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   58.02%   58.02%           
=======================================
  Files         179      179           
  Lines       11634    11634           
=======================================
  Hits         6751     6751           
  Misses       4883     4883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@withinfocus withinfocus changed the title [SM-1288] - Configure renovate to track go depenedencies [SM-1288] - Configure renovate to track go dependencies May 30, 2024
@tangowithfoxtrot tangowithfoxtrot merged commit 9eb9ef7 into main May 31, 2024
107 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the sm-1288-configure-renovate-for-go branch May 31, 2024 13:48
@withinfocus
Copy link
Contributor

@tangowithfoxtrot as a heads up when I go to #1 and see what it's inspecting, those Go versions are 1.20 and 1.18 but we have a constraint here on 1.21. You may need to manually get some updates in as the constraint might be short-circuiting this.

@tangowithfoxtrot
Copy link
Contributor Author

Created #816 to address the Go versions in our modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants