Ac/ac 2646/remove fc mvp code #4281
Draft
+173
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of double enumeration warnings, refs AC-2646
|
New Issues
Fixed Issues
|
eliykat
requested changes
Jul 5, 2024
| @@ -20,9 +20,12 @@ namespace Bit.Core.Test.AdminConsole.OrganizationFeatures.Groups; | |||
| [SutProviderCustomize] | |||
| public class CreateGroupCommandTests | |||
| { | |||
| [Theory, OrganizationCustomize(UseGroups = true, FlexibleCollections = false), BitAutoData] | |||
| [Theory, OrganizationCustomize(UseGroups = true, FlexibleCollections = true), BitAutoData] | |||
There was a problem hiding this comment.
FlexibleCollections should actually default to false, as the goal of these changes is to enable us to drop the FlexibleCollections column; the new FC code should be executed for all organizations. Best to remove it from here altogether.
Suggested change
| [Theory, OrganizationCustomize(UseGroups = true, FlexibleCollections = true), BitAutoData] | |
| [Theory, OrganizationCustomize(UseGroups = true), BitAutoData] |
Same for all other uses of this customization.
| await sutProvider.GetDependency<IReferenceEventService>().Received(1).RaiseEventAsync( | ||
| Arg.Is<ReferenceEvent>(e => e.Type == ReferenceEventType.VaultImported)); | ||
| } | ||
|
|
||
| [Theory, BitAutoData] | ||
| public async Task ImportCiphersAsync_IntoOrganization_WithFlexibleCollectionsEnabled_Success( |
There was a problem hiding this comment.
Remove references to FC being enabled/disabled:
Suggested change
| public async Task ImportCiphersAsync_IntoOrganization_WithFlexibleCollectionsEnabled_Success( | |
| public async Task ImportCiphersAsync_IntoOrganization_Success( |
Please check all other tests to see if there are any other tests that need to be renamed or deleted. (e.g. if there are tests for with & without FC enabled, they'll now both be running the same code)
There was a problem hiding this comment.
WithFlexibleCollectionsEnabled
WithFlexibleCollections
FlexibleCollectionsDisabled
WithoutFlexibleCollections
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4281 +/- ##
==========================================
- Coverage 41.20% 41.17% -0.03%
==========================================
Files 1265 1265
Lines 60333 60295 -38
Branches 5516 5510 -6
==========================================
- Hits 24861 24829 -32
+ Misses 34325 34314 -11
- Partials 1147 1152 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes