-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-9267] Add Inline Menu Positioning Improvements Feature Flag #4387
Merged
cagonzalezcs
merged 4 commits into
main
from
autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
Jul 15, 2024
Merged
[PM-9267] Add Inline Menu Positioning Improvements Feature Flag #4387
cagonzalezcs
merged 4 commits into
main
from
autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
=======================================
Coverage 41.52% 41.52%
=======================================
Files 1268 1268
Lines 60023 60023
Branches 5492 5492
=======================================
Hits 24925 24925
Misses 33948 33948
Partials 1150 1150 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
…inline-menu-re-architecture
jprusik
changed the title
[PM-9267] Add Inline Menu Positioning Improvements Fature Flag
[PM-9267] Add Inline Menu Positioning Improvements Feature Flag
Jun 28, 2024
jprusik
previously approved these changes
Jun 28, 2024
…inline-menu-re-architecture
…inline-menu-re-architecture
jprusik
approved these changes
Jul 15, 2024
cagonzalezcs
deleted the
autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
branch
July 15, 2024 17:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
bitwarden/clients#9845
📔 Objective
This PR is being made with consideration to the scope of behavioral changes within bitwarden/clients#8431
We want to ensure that the inline menu positioning enhancement can be reversed in the case of unexpected issues when deployed.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes