Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9267] Add Inline Menu Positioning Improvements Feature Flag #4387

Conversation

cagonzalezcs
Copy link
Contributor

🎟️ Tracking

bitwarden/clients#9845

📔 Objective

This PR is being made with consideration to the scope of behavioral changes within bitwarden/clients#8431

We want to ensure that the inline menu positioning enhancement can be reversed in the case of unexpected issues when deployed.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.52%. Comparing base (25dc0c9) to head (6bad778).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4387   +/-   ##
=======================================
  Coverage   41.52%   41.52%           
=======================================
  Files        1268     1268           
  Lines       60023    60023           
  Branches     5492     5492           
=======================================
  Hits        24925    24925           
  Misses      33948    33948           
  Partials     1150     1150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Logo
Checkmarx One – Scan Summary & Details56bf38c8-6aa5-4635-b6a2-05d507f49d84

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 122 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 110 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Public/Controllers/CollectionsController.cs: 87
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 358
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 171
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 98
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 88
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 148
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 222
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 174
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 222
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 583
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 583
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 198
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 628
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 607
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 657
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 583
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 174

@jprusik jprusik changed the title [PM-9267] Add Inline Menu Positioning Improvements Fature Flag [PM-9267] Add Inline Menu Positioning Improvements Feature Flag Jun 28, 2024
jprusik
jprusik previously approved these changes Jun 28, 2024
@cagonzalezcs cagonzalezcs enabled auto-merge (squash) July 15, 2024 17:16
@cagonzalezcs cagonzalezcs merged commit 60cdf9d into main Jul 15, 2024
42 of 43 checks passed
@cagonzalezcs cagonzalezcs deleted the autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture branch July 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants