[AC-2731] Remove AccessAll - Collection and Cipher functions #4469
+138
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliykat
commented
Jul 5, 2024
There was a problem hiding this comment.
Migration filename assumes that #4468 will be merged first.
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4469 +/- ##
=======================================
Coverage ? 41.34%
=======================================
Files ? 1265
Lines ? 60113
Branches ? 5509
=======================================
Hits ? 24852
Misses ? 34115
Partials ? 1146 ☔ View full report in Codecov by Sentry. |
Jingo88
approved these changes
Jul 8, 2024
rkac-bw
approved these changes
Jul 8, 2024
…herdetails---remove-accessall
…herdetails---remove-accessall
eliykat
deleted the
ac/ac-2731/usercollectiondetails-and-usercipherdetails---remove-accessall
branch
withinfocus
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Remove AccessAll logic from UserCollectionDetails and UserCipherDetails and EF equivalents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-2731
📔 Objective
Remove
AccessAlllogic from Collection and Cipher functions:These are some of our core functions for syncing the user's vault and should be reviewed carefully.
We'd already made v2 versions of these functions with these changes, but they were mostly unused. Now that the feature is released there's no need to fully switch over to the v2 versions, we can just update the old functions in place to make everything consistent again.
This PR copies the v2 logic (without AccessAll) back to the current functions. We'll drop the v2 sprocs in a later PR.
Note that this does not change the function parameters so there should be no other EDD concerns.
Similar changes are made to the EF queries, permanently switching over to the
vNextmethods in the corresponding query classes.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes