-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2731] Remove AccessAll - Collection and Cipher functions #4469
[AC-2731] Remove AccessAll - Collection and Cipher functions #4469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration filename assumes that #4468 will be merged first.
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4469 +/- ##
=======================================
Coverage ? 41.34%
=======================================
Files ? 1265
Lines ? 60113
Branches ? 5509
=======================================
Hits ? 24852
Misses ? 34115
Partials ? 1146 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…herdetails---remove-accessall
…herdetails---remove-accessall
* Remove AccessAll logic from UserCollectionDetails and UserCipherDetails and EF equivalents
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-2731
📔 Objective
Remove
AccessAll
logic from Collection and Cipher functions:These are some of our core functions for syncing the user's vault and should be reviewed carefully.
We'd already made v2 versions of these functions with these changes, but they were mostly unused. Now that the feature is released there's no need to fully switch over to the v2 versions, we can just update the old functions in place to make everything consistent again.
This PR copies the v2 logic (without AccessAll) back to the current functions. We'll drop the v2 sprocs in a later PR.
Note that this does not change the function parameters so there should be no other EDD concerns.
Similar changes are made to the EF queries, permanently switching over to the
vNext
methods in the corresponding query classes.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes