-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2847] Simplify OrganizationUser and Group PUT methods and tests #4479
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4479 +/- ##
==========================================
+ Coverage 41.49% 41.57% +0.07%
==========================================
Files 1268 1268
Lines 59986 60087 +101
Branches 5486 5508 +22
==========================================
+ Hits 24893 24980 +87
- Misses 33938 33948 +10
- Partials 1155 1159 +4 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Nicely detailed unit tests
@r-tome I've made some further changes to future-proof this, please see discussion on the ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-2847
📔 Objective
Review and tidy up the OrganizationUser and Group controller PUT methods and simplify their test coverage. This is largely done by moving their tests to a separate file and simplifying/DRYing up the mocks used for setup.
See the ticket above for more detail.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes