Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PR template #69

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Simplify PR template #69

merged 1 commit into from
Mar 8, 2024

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Feb 29, 2024

๐ŸŽŸ๏ธ Tracking

Internal change.

๐Ÿ“” Objective

Removes change type and file-based descriptions of changes. Rationale is that the type of change can be inferred and is almost always tied to tasks in Jira so it is repetitive to mark a PR in any way when the work will be explained elsewhere (including in the PR itself). Similarly, describing file changes often goes out of sync and is again a discussion in the PR content, often with inline comments left by the author.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review March 6, 2024 17:56
@withinfocus withinfocus requested a review from a team as a code owner March 6, 2024 17:56
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree these sections are duplicative.

@withinfocus withinfocus merged commit ae674f6 into main Mar 8, 2024
6 checks passed
@withinfocus withinfocus deleted the simpler-pr-template branch March 8, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants