Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-30] PR version labels #84

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Conversation

michalchecinski
Copy link
Contributor

@michalchecinski michalchecinski commented May 20, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-30

📔 Objective

Compute next version number based on label on PR: version:major, version:minor, version:patch, version:skip

If a version label is not provided on the PR, the PR is blocked from being merged.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner May 20, 2024 09:56
Copy link

github-actions bot commented May 20, 2024

Logo
Checkmarx One – Scan Summary & Detailsab4afc70-f595-49fa-bb0d-6d931500391e

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /labels.yml: [13](https://github.com/bitwarden/template/blob/BRE-30-PR-version-labels//.github/workflows/labels.yml# L13) Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Copy link
Member

@vgrassia vgrassia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a note here to what we discussed in Slack. This should be moved to the gh-actions repository as reusable workflows.

@michalchecinski michalchecinski enabled auto-merge (squash) June 19, 2024 15:07
@michalchecinski michalchecinski merged commit 9342ac1 into main Jun 19, 2024
4 checks passed
@michalchecinski michalchecinski deleted the BRE-30-PR-version-labels branch June 19, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants