Skip to content

Commit

Permalink
Merge pull request #659 from bitzesty/new-tab-nominations
Browse files Browse the repository at this point in the history
Adds target _blank to nomination table links
  • Loading branch information
TheDancingClown authored Feb 16, 2024
2 parents c059ba5 + ed868dc commit 8675b1a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
td.govuk-table__cell = check_box_tag "check_#{obj.id}", obj.id, false, class: "form-answer-check", aria: { label: "Select nomination #{obj.id} for bulk action" }
td.td-title.govuk-table__cell
- if obj.company_or_nominee_name.present?
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: "View submitted nomination for #{obj.company_or_nominee_name}" }, class: 'govuk-link' do
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: "View submitted nomination for #{obj.company_or_nominee_name}" }, class: 'govuk-link', target: :_blank do
= obj.company_or_nominee_name
- else
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: "View submitted nomination, nominee name not yet specified" }, class: 'govuk-link' do
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: "View submitted nomination, nominee name not yet specified" }, class: 'govuk-link', target: :_blank do
em
' Not yet specified
td.govuk-table__cell = obj.dashboard_status
Expand All @@ -35,5 +35,5 @@
= obj.last_updated_by
td.govuk-table__cell
- aria_label = obj.company_or_nominee_name.present? ? "View submitted nomination, for #{obj.company_or_nominee_name}" : "View submitted nomination, nominee name not yet specified"
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: aria_label }, class: 'govuk-link' do
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: aria_label }, class: 'govuk-link', target: :_blank do
| View
4 changes: 2 additions & 2 deletions app/views/assessor/form_answers/_list_body.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ tbody.govuk-table__body
- FormAnswerDecorator.decorate_collection(@form_answers).each do |obj|
tr.govuk-table__row
th.govuk-table__header scope="row"
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), class: 'govuk-link' do
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), class: 'govuk-link', target: :_blank do
- unless obj.nominee_name.nil?
span
= obj.nominee_name
Expand Down Expand Up @@ -33,5 +33,5 @@ tbody.govuk-table__body

td.govuk-table__cell
- aria_label = obj.company_or_nominee_name.present? ? "View submitted nomination, for #{obj.company_or_nominee_name}" : "View submitted nomination, nominee name not yet specified"
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: aria_label }, class: 'govuk-link' do
= link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: aria_label }, class: 'govuk-link', target: :_blank do
| View

0 comments on commit 8675b1a

Please sign in to comment.