Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 7 upgrade #623

Merged
merged 20 commits into from
Nov 21, 2023
Merged

Rails 7 upgrade #623

merged 20 commits into from
Nov 21, 2023

Conversation

dreamfall
Copy link
Contributor

@dreamfall dreamfall commented Nov 16, 2023 •
edited
Loading

📝 A short description of the changes

  • upgrade to rails 7
  • upgrade ruby to 3.2
  • use zeitwerk
  • update jQuery to ver 3 and fix issues with multiple jQs loaded in rails 7

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@dreamfall dreamfall requested a review from saenom November 16, 2023 14:43
@dreamfall dreamfall marked this pull request as ready for review November 16, 2023 14:43
saenom
saenom requested changes Nov 17, 2023
View reviewed changes
app/javascript/components/session_timeout.js Outdated
@@ -1,5 +1,5 @@
import MicroModal from 'micromodal';
import 'jquery/src/jquery';
// import 'jquery/src/jquery';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove it?

app/javascript/packs/application.js Outdated
@@ -19,7 +19,7 @@ const frontend = require("govuk-frontend/govuk/all")
require.context('govuk-frontend/govuk/assets/images', true)
import './application.scss';

import 'jquery/src/jquery';
// import 'jquery/src/jquery';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove it?

config/initializers/permissions_policy.rb Outdated
@@ -0,0 +1,11 @@
# Define an application-wide HTTP permissions policy. For further
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove it?

Gemfile.lock
@@ -32,73 +32,87 @@ GEM
remote: https://rubygems.org/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run bundle update?

@dreamfall dreamfall merged commit b761064 into main Nov 21, 2023
2 checks passed
@dreamfall dreamfall deleted the rails-upgrade branch November 21, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saenom saenom saenom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamfall @saenom