Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passes search and page params to paths #660

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Passes search and page params to paths #660

merged 8 commits into from
Feb 16, 2024

Conversation

TheDancingClown
Copy link
Contributor

📝 A short description of the changes

  • We would like to retain search or page results navigating back after viewing users and nominations. To do this we permit search params in the admin user controllers and pass the params when navigating/using controller methods.
  • The changes are applied to nominations tables and admin user tables (users, lieutenants, assessors, group leaders and admins)
  • Back to users breadcrumb has been updated to return the admin to the relevant user path instead of always returning to nominators table.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@TheDancingClown TheDancingClown marked this pull request as ready for review February 16, 2024 10:22
@TheDancingClown TheDancingClown merged commit 42eb511 into main Feb 16, 2024
2 checks passed
@TheDancingClown TheDancingClown deleted the page-params branch February 16, 2024 13:55
@TheDancingClown TheDancingClown mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants