Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to installing as shared #1

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Fixes to installing as shared #1

merged 4 commits into from
Apr 29, 2021

Conversation

bwrsandman
Copy link
Collaborator

@bwrsandman bwrsandman commented Apr 29, 2021 •
edited
Loading

Cross PR to widberg#100

  • cmake: turn on CMAKE_POSITION_INDEPENDENT_CODE for shared
    • This prevents an error while linking static libs into shared libs on linux
  • install bx and bimg as shared libs if building as shared
  • don't install static libs if shared libs have been built

@bwrsandman
cmake: turn on CMAKE_POSITION_INDEPENDENT_CODE for shared
db7e9cb 
This prevents an error while linking libbx.a into libbgfx.so on linux
@bwrsandman
bimg: specify visibility of linked libs
3935d45
@bwrsandman
install: if generating shared, only install bgfx
bf668bf
@bwrsandman
bgfx: make bx and bimg private
2e98471 
This makes it so in shared mode, bx and bimg static libs aren't installed
@bwrsandman bwrsandman requested a review from exdal April 29, 2021 17:47
@bwrsandman bwrsandman merged commit f8f30ca into bkaradzic:master Apr 29, 2021
exdal added a commit that referenced this pull request May 2, 2021
@exdal
Merge pull request #1 from bkaradzic/master
c26667f 
Update fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exdal exdal exdal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwrsandman @exdal