Fix handling of inline tables #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used this file and clippy -- -A clippy::all -D clippy::disallowed_methods to find the places I needed to fix.
bkchr
reviewed
Mar 5, 2025
This will stop this bug sneaking back in. Doing this here saves having to duplicate all the tests with versions that use inline tables instead. (We'll have one test, though.)
|
I've added a single test case, which does indeed fail now for me locally if I revert "toml_edit tables: Use TableLike and .as_table_like". I considered how to prevent calls to I don't have much experience with github CI (I mostly work with gitlab) so I hope what I've done (a) looks sane and (b) works. |
bkchr
approved these changes
Mar 6, 2025
Ty! All looks good. :) |
|
Thanks :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
I think this may have been broken as a side effect of 56a40f1 apparently released in 1.3.0 (!)