Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bkerler, this should be the correct setactiveslot change of
attributes
andtype
for each partition.Warning: This is qualcomm-specific, and is very slow
20s - 30s-> ~5s-15s since it looks for corresponding partitions for each switch, so it will need to be improved in the futureThis is how fastboot does it. it swaps the type of active partitions with their corresponding inactive partitions, and add + unset active bit corresponding to the new active slot. Moreover,
boot
partitions have additional attribute/flag settings derived from fastboot implementation such asretry_count
,priority_val
,bootability
qcomm abl doesn't set the
success_val
at the bit offset 54 until it boots successfully for "boot partition fall back" if there were error with booting process. Not sure if it is safe to set it in qdl mode prior to the successful boot?