Fix MSVC_RUNTIME_LIBRARY inconsistencies #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was pretty tough to detect, I found it accidentally, as I need to build a Debug LLVM, which uses the In my localised MSVC the error(s) looks like: The first one detects the MSVC STL ABI differences related to their debug iterators (they could handle some typical errors as runtime errors), the second is our root cause. The old MSVCs actually could link the libraries with distinct runtimes, but final executable would definitely crash on any ABI boundary |
Use CMake defaults as sane default, as LLVM also uses it by default. 1. The policy was ambiguous as CMake sets it to NEW since CMake 3.15 (as we have CMake 3.16); 2. The `/MD` flag just override the target's property MSVC_RUNTIME_LIBRARY, so all configuration types used the /MD flag (instead of CMAKE_MSVC_RUNTIME_LIBRARY); 3. The manual override for CMAKE_MSVC_RUNTIME_LIBRARY was removed as a potential ODR-violation against LLVM's used MSVC runtime and a real runtime mismatch (which follows to LNK2038 error with text like "Detected mismatch for "RuntimeLibrary": value "MDd_DynamicDebug" doesn't match value "MD_StaticDebug").
leha-bot
force-pushed
the
fix/msvc-inconsistent-runtimes
branch
from
2d3a8ee to
57f7280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CMake defaults as sane default, as LLVM also uses it by default.
/MDflag just override the target's property MSVC_RUNTIME_LIBRARY, so all configuration types used the /MD flag (instead of CMAKE_MSVC_RUNTIME_LIBRARY);