Add pitch shifter effect digitech drop/whammy/ricochet #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xconverge
commented
Oct 31, 2024
| ProcessMono(inL); | ||
| } | ||
|
|
||
| float clamp(float v, float min, float max) { |
There was a problem hiding this comment.
this can be removed if the project moves to c++17 or c++20
xconverge
commented
Nov 3, 2024
| /** Shift can be 30-100 ms lets just start with 50 for now. | ||
| 0.050 * SR = 2400 samples (at 48kHz) */ | ||
| // static constexpr size_t kShiftDelaySize = 16384; | ||
| static constexpr size_t kShiftDelaySize = 2048; |
There was a problem hiding this comment.
setting this to ~5000+ makes a full octave sound pretty good, but the latency is pretty terrible and the buffers take up a lot of space. I could move stuff to SDRAM probably, but that won't fix the latency, and reallocating with a changing value here based on the selected octave seems not worth it really. Easiest would probably be to just remove the full octave setting for now, and just stay at +-5 or so semitones for now, but the others aren't hurting anything, they just don't sound good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a clean-ish PR if DaisySP merged the PR electro-smith/DaisySP#166 and parameterized the buffer size
I wanted to at least document this in case anyone else is interested since this PR runs quite nicely as is
The knobs are mapped to:
There is a UI when in momentary mode that shows shift/return status.
I mostly will either use this latched/dropped 1 semitone for Eb tuning. Beyond that can start to sound a little off IMO. Momentary mode is also really fun and can make some super interesting stuff, I have used this the most so far just because of how fun it is.