-
Notifications
You must be signed in to change notification settings - Fork 34
Exposed methods for disabling/enabling platform menu items in the contex... #476
base: next
Are you sure you want to change the base?
Exposed methods for disabling/enabling platform menu items in the contex... #476
Conversation
API Docs: blackberry/WebWorks-API-Docs#403 |
listDisabledPlatformItems doesn't seem to work. But the WP API works. |
Fixed listDisabledPlatformItems() |
@ishneur Can you test this one out? |
Missing functional tests |
@ishneur can you give this a quick test |
Tested and works correctly with some issues/comments:
|
@erikj54 - is this expected? |
|
@erikj54 When I set actionId = "MenuService-0" inside disablePlatformItem(), the Share menu item is disabled. |
Another issue I noticed is that if you disable an item (e.g. ACTION_COPY) for CONTEXT_ALL, and then try to enable it for a particular context, e.g. CONTEXT_LINK, it doesn't work and returns "false", so the only way to enable it again is to enable it for CONTEXT_ALL. The same issue happens the other way around: if you disable an item for CONTEXT_LINK and then try to enable it for CONTEXT_ALL, it returns "false" too and the item is not added back for link. I don't know if the above is intended or not, but it looks like the same context must be specified for enable/disable in order for it to work, even when enabling/disabling for CONTEXT_ALL. |
The above seems like a bug. @rcruz |
We'll fix the list to display a more accurate listing, and the CONTEXT_ALL combinations. |
FYI depends on http://github.rim.net/webworks/webplatform/pull/259 targetted at 10.2, will merge after we branch |
...t menu