fix(netops): fix ip addr flush command (canonical#5651)

Drop unnecessary environment variable. Fixes canonicalGH-5648
blackboxsw · Sep 4, 2024 · 6963dcc · 6963dcc
1 parent 10449cb
commit 6963dcc
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/cloudinit/net/netops/iproute2.py b/cloudinit/net/netops/iproute2.py
@@ -130,7 +130,6 @@ def add_addr(
                 "dev",
                 interface,
             ],
-            update_env={"LANG": "C"},
         )
 
     @staticmethod
@@ -141,4 +140,4 @@ def del_addr(interface: str, address: str):
 
     @staticmethod
     def flush_addr(interface: str):
-        subp.subp(["ip", "flush", "dev", interface])
+        subp.subp(["ip", "addr", "flush", "dev", interface])
diff --git a/tests/unittests/net/test_init.py b/tests/unittests/net/test_init.py
@@ -836,7 +836,6 @@ def test_ephemeral_ipv4_network_performs_teardown(self, m_subp):
                     "dev",
                     "eth0",
                 ],
-                update_env={"LANG": "C"},
             ),
         ]
         expected_teardown_calls = [
@@ -973,7 +972,6 @@ def test_ephemeral_ipv4_network_with_prefix(self, m_subp):
                         "dev",
                         "eth0",
                     ],
-                    update_env={"LANG": "C"},
                 )
             ]
         )
@@ -992,7 +990,6 @@ def test_ephemeral_ipv4_network_with_prefix(self, m_subp):
                         "dev",
                         "eth0",
                     ],
-                    update_env={"LANG": "C"},
                 )
             ]
         )
@@ -1023,7 +1020,6 @@ def test_ephemeral_ipv4_network_with_new_default_route(self, m_subp):
                     "dev",
                     "eth0",
                 ],
-                update_env={"LANG": "C"},
             ),
             mock.call(["ip", "route", "show", "0.0.0.0/0"]),
             mock.call(
@@ -1104,7 +1100,6 @@ def test_ephemeral_ipv4_network_with_rfc3442_static_routes(self, m_subp):
                     "dev",
                     "eth0",
                 ],
-                update_env={"LANG": "C"},
             ),
             mock.call(
                 [