Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exercise/highcharts 3 #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Exercise/highcharts 3 #2

wants to merge 6 commits into from

Conversation

KamilKubik
Copy link
Collaborator

No description provided.

mfilipiec
mfilipiec suggested changes Oct 10, 2022
View reviewed changes
Copy link

@mfilipiec mfilipiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general good job and it's cool that you used the translate method instead of attr. I only have a few small comments, but mostly stylistic and visual.

mfilipiec
mfilipiec approved these changes Oct 10, 2022
View reviewed changes
Copy link

@mfilipiec mfilipiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfilipiec mfilipiec mfilipiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KamilKubik @mfilipiec