Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise/highcharts 2 #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+100 −0
Open

Exercise/highcharts 2 #3

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
560d4b8
Apply initial version
Oct 6, 2022
8e3fd01
Apply initial changes
Oct 6, 2022
973c5ca
Apply finished version
Oct 6, 2022
68d1c7a
Code refactor
Oct 6, 2022
d42de02
Code refactor
Oct 7, 2022
b6ecd97
Applied code review fixes
Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions highcharts-api/highcharts/2-polar-rings/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1">

<script src="https://code.highcharts.com/highcharts.js"></script>
<script src="https://code.highcharts.com/highcharts-more.js"></script>

</head>

Expand Down
106 changes: 106 additions & 0 deletions highcharts-api/highcharts/2-polar-rings/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
const generateRandomSeriesData = () =>
Array.from({ length: 3 }, () => Math.floor(Math.random() * 10));

const chart = Highcharts.chart("container", {
chart: {
type: "column",
polar: true,
events: {
load() {
const yAxis = this.yAxis[0],
dataMax = yAxis.dataMax;

yAxis.update({
max: dataMax * 2
});

yAxis.addPlotLine({
dashStyle: "Dash",
value: dataMax * 1.5,
width: 2
});

const redCircle = this.renderer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a circle on load is not necessary when you use render as well. Try to figure out, how to add a circle only by using render event. Also, take note, that your circle is not fully responsive (you added a fixed radius value, but it should be changing as x and y)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the circle render to the render event, refactored the whole event and added the responsiveness (r parameter which I missed). Thanks!

.circle(
this.plotWidth / 2 + this.plotLeft,
this.plotHeight / 2 + this.plotTop,
100
)
.attr({
fill: "white",
stroke: "red",
"stroke-width": 2
})
.add();

this.redCircle = redCircle;
},
render() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have only two suggestions:

  • radius is not quite responsive this way (it changes via Math.random() every time when you redraw the chart, but it should only base on the value from the chart and scale relative to the chart ( toPixels() is a good choice 🥇 )
  • if you first check that the circle doesn't exist, you avoid a few code lines

Generally, you can simplify it following way:

    events: {
      render: function() {
        const chart = this,
          yAxis = this.yAxis[0];

        if (!chart.customCircle) {
          chart.customCircle = chart.renderer
            .circle()
            .attr({
              stroke: "blue",
              "stroke-width": 3,
              fill: "none"
            })
            .add();
        }

        chart.customCircle.attr({
          x: chart.yAxis[0].center[0] + chart.plotTop,
          y: chart.yAxis[0].center[1] + chart.plotLeft,
          r: chart.yAxis[0].toPixels(chart.yAxis[0].dataMax)
        });

      }
    }

const redCircle = this.redCircle;

if (redCircle) {
redCircle.attr({
cx: this.plotWidth / 2 + this.plotLeft,
cy: this.plotHeight / 2 + this.plotTop
});
}
}
}
},
title: {
text: undefined
},
pane: {
startAngle: 0,
endAngle: 360
},
xAxis: {
categories: ["Jan", "Feb", "Mar"]
},
yAxis: {
min: 0,
endOnTick: false,
title: {
text: undefined
},
plotLines: [
{
width: 2,
color: "green",
value: 15,
dashStyle: "solid"
}
]
},
credits: {
enabled: false
},
series: [
{
name: "Tokyo",
data: generateRandomSeriesData()
},
{
name: "New York",
data: generateRandomSeriesData()
},
{
name: "London",
data: generateRandomSeriesData()
}
],
plotOptions: {
series: {
dataLabels: {
enabled: true,
formatter() {
return this.y === this.series.yAxis.dataMax ? "max" : "";
}
}
},
column: {
pointPadding: 0,
groupPadding: 0
}
}
});