-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highcharts/12 hover label highlight #12
base: main
Are you sure you want to change the base?
Conversation
…altering the category-data itself
I suspect that having a seperate variable outside of the chart to hold the highlighted category, might not be ideal
Feel free to tell me no x)! I realize i could flag points as selected in the mouseOver/mouseOut-callbacks, and i suspect that using that there is a way ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the task is done correctly. I really like your solution because it's short, efficient and you're using highcharts functions. However, it has one drawback that I wrote down below. Please take a look. :)
Besides that you can only remove some unnecessary code like removing the titles of the chart, axes, etc, the categories should also be 'Jan, Feb...' not years, but that's of course not the case with this task.
Hey, K009! I looked closer at the redraw-function and realized i could disable animation only for the single redraw-call instead of disabling animation in general for the whole chart x) EDIT: Oh, and sorry, I will fix the category-text and stuff as well to fit the screenshot provided! |
…unc to better fit screenshot
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Markus, now it looks much better. Thanks for that 😄
No description provided.