Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highcharts/13 syncronized pies #13

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MarkusBarstad
Copy link
Contributor

No description provided.

@MarkusBarstad MarkusBarstad self-assigned this Sep 7, 2022
Copy link

@hihajdus hihajdus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everything looks good 🙂👍
one feature to add, to show the tooltip in both series.

}
});
},
mouseOver: function(e) {
Copy link

@hihajdus hihajdus Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do:

  • Add a feature to show the tooltip in both series.
    (So that when the cursor hovers over a point in series1, the tooltip also appears in series2, and vice versa)

Tip:
You can get to the tooltip options from point.events.mouseOver and point.events.mouseOut this.series.chart.tooltip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I will try this now!

Copy link

@hihajdus hihajdus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool solution,

Thanks Markus 👏 for all your work on the exercises, you rock in Highcharts.

}
},
events: {
load() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea to create a custom tooltip in events.load() 👍

Small cosmetic fix, you can add spacing of the if condition.

        if (p.name === pointName) {
          p.setState('hover');
          chart.customTooltip.refresh(p);
        } else {
          p.setState('inactive');
        }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix! Forgot to run it thru jsfiddle this morning! time to get a proper linter set up ;)

@MarkusBarstad
Copy link
Contributor Author

MarkusBarstad commented Oct 4, 2022

Thank you so much for your kind words and guidance, man, I am learning a lot from you and the other people at BlackLabel!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants