-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highcharts/4 seperate axes #5
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Markus! The exercise is done correct. However I've found some things that can be improved. Please take a look at them.
Thank you for good feedback, I will look at it now! :) |
Ok, i have fixed stuff up a bit, hope you like it! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the further changes! Three general notes before digging into the code.
-
Do you have an option to mark the conversation resolved? If yes please mark it that way. It would make the pull request more readable for us. I'm talking about such button:
-
It's always a good idea to make the whole demo responsive, so please don't remove the lines in your code that are resizing elements depending on the screen size. Our goal is to always make the demo work for all screen sizes. 😄
-
I also suggest declaring such variable as
const chart = this
inside the render function, to make the whole function easier to read. Sometimes we might not be sure whatthis
is referring to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost at the finish line, only one thing to fix! Besides that, I like the way of using xAxis to draw the categories in the center and other improvements.
Seems better now! removed that line and did just like you said, modified the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks for all the changes!
Thank you, man! :D |
No description provided.