Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding zone transfer module #395

Merged
merged 2 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions baddns/lib/findings.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ def __init__(self, finding_dict):
raise BadDNSFindingException("Module was not a valid baddns module")
self.finding_dict["module"] = module.name

data = finding_dict.get("data", None)
if data:
self.finding_dict["data"] = data

def to_dict(self):
return self.finding_dict

Expand Down
81 changes: 81 additions & 0 deletions baddns/modules/zonetransfer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
from baddns.base import BadDNS_base
from baddns.lib.findings import Finding
from baddns.lib.dnsmanager import DNSManager

import logging
import dns.zone
import dns.query

log = logging.getLogger(__name__)


class BadDNS_zonetransfer(BadDNS_base):
name = "zonetransfer"
description = "Attempt a DNS zone transfer"
zone_records = []
zone_nameservers = []

def __init__(self, target, **kwargs):
super().__init__(target, **kwargs)

self.target_dnsmanager = DNSManager(target, dns_client=self.dns_client)

def parse_zone(self, zone):
for name, node in zone.nodes.items():
for rdataset in node.rdatasets:
record_type = dns.rdatatype.to_text(rdataset.rdtype)
for rdata in rdataset:
raw_name = name.to_text()
if str(raw_name) == "@":
processed_name = self.target_dnsmanager.target
else:
processed_name = f"{raw_name}.{self.target_dnsmanager.target}"
record = (processed_name, record_type, rdata.to_text())
if record not in self.zone_records:
self.zone_records.append(record)

async def zone_transfer(self, nameserver, domain):
ns_ips = await self.target_dnsmanager.do_resolve(nameserver, "A")
ns_ip = ns_ips[0]
try:
zone = dns.zone.from_xfr(dns.query.xfr(ns_ip, domain, timeout=10))
except TimeoutError:
log.warning("TimeoutError attempting zone transfer")
return False
except dns.xfr.TransferError as e:
log.debug(f"{nameserver} ({ns_ip}): {e}")
return False
self.zone_nameservers.append(nameserver)
self.parse_zone(zone)
return True

async def dispatch(self):
await self.target_dnsmanager.dispatchDNS(omit_types=["A", "MX", "AAAA", "CNAME", "SOA", "TXT"])
if self.target_dnsmanager.answers["NS"]:
for ns in self.target_dnsmanager.answers["NS"]:
log.debug(f"Attempting Zone Transfer against NS [{ns}] for target [{self.target_dnsmanager.target}]")
r = await self.zone_transfer(ns, self.target_dnsmanager.target)
if r:
log.info(
f"Successful Zone Transfer against NS [{ns}] for target [{self.target_dnsmanager.target}]"
)
return True

def analyze(self):
findings = []
if self.zone_records:
findings.append(
Finding(
{
"target": self.target_dnsmanager.target,
"description": "Successful Zone Transfer",
"confidence": "CONFIRMED",
"signature": "N/A",
"indicator": "Successful XFR Request",
"trigger": self.zone_nameservers,
"module": type(self),
"data": self.zone_records,
}
)
)
return findings
Loading