Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable tailwind css option for ui styling #85

Draft
wants to merge 1 commit into
base: proto/dev
Choose a base branch
from

Conversation

ianyimi
Copy link

@ianyimi ianyimi commented Feb 11, 2025

I chose a pretty simple way to handle this. I can also add a text input in the settings for a cdn link if users want to choose their specific tailwind version that gets loaded or a dropdown select with various versions. Here I have just hardcoded the most recent stable version from the cdn. Not sure how well this will play if the cdn is ever unavailable, or the user if offline. for this case I can download a copy of the minified cdn script and save it somewhere in the project files, though these are just some thoughts I am having now, while writing this. Im using this forked version from dev in my own vault, Im just getting around to rebuilding it after having come across this plugin. I was a heavy dataview user mid last year, but my extensive querying ended up rendering my first vault unusable and I fell out of practice.

@ianyimi ianyimi marked this pull request as draft February 11, 2025 05:16
@ianyimi
Copy link
Author

ianyimi commented Feb 11, 2025

Upon reconsideration this feature doesnt really need to be included in this plugin, as the same effect can be achieved by moving the new function in ~/src/index/datacore.ts to a separate js file and running it on vault start with something like the homepage plugin. Honestly, I only made this pr so I wouldn't have to deal w rebasing this change up for every new release, like I did for a few other plugins. I'll leave this here as a draft in case others find it useful, but nbd if it's closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant