Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar preview shows correct files for each dot #2401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TKDKid1000
Copy link

@TKDKid1000 TKDKid1000 commented Jul 28, 2024

Fixes #1798 with a stable dot hover detection system.

The issue was that, if you hovered a day on the calendar preview, you would only be able to see the first file from that day. This allows you to hover over a specific dot to see a specific file from that day. I wrote an initial implementation, then looked and saw lizhuoran1019@3afb3c7, which seemed to be a bit similar to mine, and theirs had some flaw in it which mine also did. The people there suggested using data- tags, which I tried, and it now seems to work quite reliably.

There is still an issue where, if you move your mouse around on the dots, multiple previews stack up back to back. I have an idea on how to fix this, but I don't know the Obsidian events API enough to be able to close a hover preview. If someone knows that, I would appreciate it, but this should resolve #1798 for now. Each dot now corresponds to an individual note created that day.

@vrouilhac
Copy link

Any update on this? This fix would be highly appreciated 👍

@TKDKid1000
Copy link
Author

I think I read somewhere that the owner basically stopped working on this project to go work on Datacore, even though the most recent commit was less than 2 weeks ago. I obviously can't know for sure though, and I'll leave this PR open until I get something definitive telling me to do otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar preview is broken when there are multiple entries per day
2 participants