Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: misp event reports #269

Merged
merged 9 commits into from
Dec 26, 2024
Merged

feat: misp event reports #269

merged 9 commits into from
Dec 26, 2024

Conversation

anasmuhmd
Copy link
Contributor

closes #130

dobarx
dobarx approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@dobarx dobarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just few minor issues with messages in diagnostics that you @traut mentioned.

@anasmuhmd anasmuhmd force-pushed the feat/misp_event_reports branch from 1b83ee6 to 0090fd1 Compare December 25, 2024 16:39
@traut
Copy link
Member

traut commented Dec 25, 2024

thanks! The last thing is there is some stale generated code - the CI check is failing. You can regenerate the code by running just generate

@anasmuhmd anasmuhmd requested a review from traut December 26, 2024 18:04
@traut traut merged commit 898b365 into blackstork-io:main Dec 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobarx dobarx dobarx approved these changes

@Andrew-Morozko Andrew-Morozko Awaiting requested review from Andrew-Morozko

@traut traut Awaiting requested review from traut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

misp_event_reports publisher in misp plugin
3 participants
@anasmuhmd @traut @dobarx